Re: [PATCH x86 for review III] [10/29] i386: don't include bugs.h

[JÃrn Engel]

On Mon, 12 February 2007 17:51:30 +0100, Andi Kleen wrote:
> 
> From: Andrew Morton <akpm@xxxxxxxx>
> 
> That stupid non-inlined-static function in bugs.h causes:
> 
> include/asm/bugs.h:186: warning: 'check_bugs' defined but not used
> 
> But fortunately the include isn't needed.
> 
> Cc: Andi Kleen <ak@xxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Andi Kleen <ak@xxxxxxx>
> 
> ---
> 
>  arch/i386/kernel/alternative.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> Index: linux/arch/i386/kernel/alternative.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/alternative.c
> +++ linux/arch/i386/kernel/alternative.c
> @@ -4,7 +4,6 @@
>  #include <linux/list.h>
>  #include <asm/alternative.h>
>  #include <asm/sections.h>
> -#include <asm/bugs.h>
>  
>  static int no_replacement    = 0;
>  static int smp_alt_once      = 0;

Didn't your patchset also include a near-identical patch from Adrian
Bunk (with - and + exchanged)?

JÃrn

-- 
Courage is not the absence of fear, but rather the judgement that
something else is more important than fear.
-- Ambrose Redmoon
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/