Re: [PATCH mm] cfag12864b: fix crash when built-in and no parport present

[Miguel Ojeda]

On 2/13/07, Daniel Walker <dwalker@xxxxxxxxxx> wrote:
> On Mon, 2007-02-12 at 21:35 -0800, Andrew Morton wrote:
>
> >
> > This looks hacky.
> >
>
> One other thing that could be added is a change in the initcalls .
> ks0108 should be subsys_initcall() and the LCD devices
> device_initcall(). That would make sure one runs before the other. I

Yes, it could be better, although it is not necessary for now (link
order is telling who should get called first).

> don't think that alone would fix the crash tho. I didn't suggest it
> before cause I think the order of the sources in the build system might
> do this implicitly even if both are in device_initcall ..

Yes, link order matters; however, the problem is related to
cfag12864b_init() being called if ks0108 failed. Indeed, if cfag12864b
is called before ks0108 is a mistake too, but it isn't happening here.

I also think the solution looks hacky (I said that I was waiting for a
better solution), and also I think it should be checked by the kernel
at boot like modprobe does; but I don't know any other solution. Any
ideas?

--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/