Re: [PATCH] sparse chokes on arch/i386/kernel/i8253.c

From: Andrew Morton
Date: Thu Feb 15 2007 - 19:40:44 EST


On Thu, 15 Feb 2007 19:23:47 -0500
Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:

> sparse chokes on arch/i386/kernel/i8253.c
>
> Here is a marker fix that puts the correct -i include/linux/marker.h in
> the top level Makefile so sparse works correctly. The tricky part is to
> keep the kernel compiling correctly with a kernel build directory
> different from the kernel source tree too.
>
> The fix applies on top the the Linux Kernel Markers for 2.6.20.
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>
>
> --- a/Makefile
> +++ b/Makefile
> @@ -309,7 +309,8 @@ AFLAGS_KERNEL =
> LINUXINCLUDE := -Iinclude \
> $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> -include include/linux/autoconf.h \
> - -include linux/marker.h
> + -include \
> + $(if $(KBUILD_SRC),$(srctree)/)include/linux/marker.h
>
> CPPFLAGS := -D__KERNEL__ $(LINUXINCLUDE)

But what is so magical about marker.h to justify special-case treatment at the
kbuid level?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/