Re: [PATCH] ACPI: ibm-acpi: improve backlight power handling

From: Henrique de Moraes Holschuh
Date: Mon Feb 26 2007 - 13:12:29 EST


On Mon, 26 Feb 2007, Richard Purdie wrote:
> On Mon, 2007-02-26 at 13:12 -0300, Henrique de Moraes Holschuh wrote:
> > @@ -1707,7 +1708,8 @@ static int brightness_write(char *buf)
> >
> > static int brightness_update_status(struct backlight_device *bd)
> > {
> > - return brightness_set(bd->props.brightness);
> > + return brightness_set((bd->props.fb_blank == FB_BLANK_UNBLANK)?
> > + bd->props.brightness : 0);
> > }
> >
> > static struct backlight_ops ibm_backlight_data = {
>
> Should we be looking at bd->props.power here too?

Probably. I will update the patch.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/