Re: [rfc][patch] dynamic resizing dentry hash using RCU

[David Miller]

From: Nick Piggin <npiggin@xxxxxxx>
Date: Fri, 23 Feb 2007 16:37:43 +0100

> So I introduce a new method for resizing hash tables with RCU, and apply
> that to the dentry hash.

Thanks for doing this work Nick.  I'm going to take your ideas
and apply them to an ipv4 routing cache dynamic growth patch I
worked on a while ago.

One minor nit:

> +struct dentry_hash {
> +	unsigned int shift;
> +	unsigned long mask;
> +	struct hlist_head *table;
> +};

I don't see any reason to make 'mask' an unsigned long
and this makes this structure take up 8 bytes more than
necessary on 64-bit.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/