Re: [patch] CPU hotplug: call check_tsc_sync_source() with irqs off

From: Michal Piotrowski
Date: Wed Mar 07 2007 - 12:47:07 EST


On 07/03/07, Ingo Molnar <mingo@xxxxxxx> wrote:

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> [ Ingo and Thomas added to Cc, because I think this is them.. ]
>
> Ingo, I think this came in during commit 95492e4646, "x86: rewrite SMP
> TSC sync code".

yeah.

> > I get this while
> > echo shutdown > /sys/power/disk; echo disk > /sys/power/state
> >
> > BUG: using smp_processor_id() in preemptible [00000001] code: swsusp_shutdown/3359
> > caller is check_tsc_sync_source+0x1b/0xef

Michal, could you try the patch below?


I think that this patch fixes the problem. Thanks!

Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group (PL)
(http://www.stardust.webpages.pl/ltg/)
LTG - Linux Testers Group (EN)
(http://www.stardust.webpages.pl/linux_testers_group_en/)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/