Re: 2.6.21-rc2-mm2: drivers/net/wireless/libertas/debugfs.c addrbogosity

From: Andrew Morton
Date: Wed Mar 07 2007 - 18:04:37 EST


On Wed, 7 Mar 2007 23:41:16 +0100
Adrian Bunk <bunk@xxxxxxxxx> wrote:

> On Tue, Mar 06, 2007 at 12:44:08AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.20-rc2-mm1:
> >...
> > git-netdev-all.patch
> >...
> > git trees
> >...
>
> drivers/net/wireless/libertas/debugfs.c contains:
> #define item_addr(n) ((u32) &((wlan_adapter *)0)->n)
>
> This is wrong on 64bit architectures.

Is OK - it is simply yet another reimplementation of offsetof(). Hint.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/