Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

From: Dave Jones
Date: Wed Mar 07 2007 - 19:09:46 EST


On Wed, Mar 07, 2007 at 06:38:32PM -0500, Robert P. J. Day wrote:
>
> Replace the apparently misspelled preprocessor variable "PRINTK"
> with "CONFIG_PRINTK".

this looks wrong.

> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 5554ada..0c09772 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -53,7 +53,7 @@
> //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
> #define DPRINTK(x...) do { } while(0)
>
> -#ifndef PRINTK
> +#ifndef CONFIG_PRINTK
> # if DEBUG > 0
> # define PRINTK(x...) printk(KERN_DEBUG x)
> # else

the intention here is to only define 'PRINTK' if no-one else
has defined it already.

Dave

--
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/