Re: [PATCH 12/20] x86_64: 64bit ACPI wakeup trampoline

[Pavel Machek]

Hi!

> > ...you'll still keep 80-column rule while keeping it readable.
> > 
> 
> Thanks. Done the changes in attached patch.
> 
> > > @@ -159,11 +159,11 @@ wakeup_32:
> > >  	 */
> > >  
> > >  	/* Finally jump in 64bit mode */
> > > -	ljmp	*(wakeup_long64_vector - __START_KERNEL_map)
> > > +        ljmp    *(wakeup_long64_vector - wakeup_code)(%esi)
> > 
> > spaces vs. tabs problem.
> > 
> 
> Thanks. Done the changes in attached patch.
...
> o Increased the size of the wakeup routine to 8K. This is required as
>   wake page tables are on trampoline itself and they got to be at 4K
>   boundary, hence one page is not sufficient.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

ACK.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/