Re: [PATCH] make elv_register() output atomic

From: Jens Axboe
Date: Thu Mar 08 2007 - 08:46:24 EST


On Thu, Mar 08 2007, Thibaut VARENE wrote:
> Hi,
>
> Booting 2.6.21-rc3-g45592145 I noticed the following on one of my
> machines in the bootlog:
>
> io scheduler noop registered<6>Time: jiffies clocksource has been installed.
>
> io scheduler deadline registered (default)
>
>
> Looking at block/elevator.c, it appears that elv_register() uses two
> consecutive printks in a non-atomic way, leading to the above glitch. The
> attached trivial patch fixes this issue, by using a single printk.

Thanks, looks like a good fix!

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/