Re: PAGE_SIZE Availability Inconsistency

From: Arjan van de Ven
Date: Thu Mar 08 2007 - 10:55:16 EST


On Thu, 2007-03-08 at 09:00 +0000, Christoph Hellwig wrote:
> On Thu, Mar 08, 2007 at 03:18:04AM +0100, Roman Zippel wrote:
> > Hi,
> >
> > On Tuesday 06 March 2007 10:29, Christoph Hellwig wrote:
> >
> > > PAGE_SIZE should not be available at all. Please use getpagesize()
> > > instead.
> >
> > While I agree, NBPG is a bit of a problem, although it's only needed for aout
> > coredumps AFAICT, but still needed to compile e.g. gdb.
>
> So we should export this one with an arbitrary value (on multiple page
> size architectures) and a warning, maybe even an __deprecated attached to
> it.

if we think the kernel should export this one, we could do

#ifndef __KERNEL__
#define PAGE_SIZE getpagesize()
#endif


--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/