Re: should RTS init in serial core be tied to CRTSCTS

From: Russell King
Date: Thu Mar 08 2007 - 15:40:57 EST


On Thu, Mar 08, 2007 at 03:23:39PM -0500, Robin Getz wrote:
> On Thu 8 Mar 2007 08:48, Russell King pondered:
> > On Thu, Mar 08, 2007 at 08:44:31AM -0500, Robin Getz wrote:
> > > That would let you change things are run time, but the problem is at
> > > boot time. A default setting needs to be set, so when things initialize,
> > > and proc does not exist yet, it is still set properly...
> >
> > I disagree. "proc does not exist yet" - the only time that applies is
> > long before userspace as active.
>
> Right - We both agree - And setting console=/dev/null in the bootargs still
> does not help.

Ok, good.

> When the kernel initializes the UART Port, it asserts RTS - which confuses
> the host it is attached to (in this case, the Linux system is the serial
> peripheral).

... which occurs /after/ userspace is up and running, when sysfs is
available. So putting it in sysfs is reasonable.

> How about adding a module_param to serial core, which the default is to
> assert RTS (as is today), and someone (like me) can override with
> serial_core.RTS=0

So all ports change behaviour with a single parameter? That'll stop
NULL modem cables with hardware flow control enabled working on other
ports without compensatory tweaking.

No, doing a system-wide change like that is _not_ a solution - it just
moves the problem elsewhere.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/