Re: [PATCH] x86_64, i386: Add command line length to boot protocol

[Dave Jones]

On Mon, Mar 12, 2007 at 10:43:52AM +0000, Pavel Machek wrote:
 > On Tue 2007-03-06 13:21:34, Dave Jones wrote:
 > > On Tue, Mar 06, 2007 at 07:14:30PM +0100, Bernhard Walle wrote:
 > > 
 > >  > +cmdline_size:   .long   COMMAND_LINE_SIZE-1     #length of the command line,
 > > 
 > > Why a long? It's unlikely that someone is going to have a command line
 > > bigger than 0xffff.
 > 
 > Well, I could imagine overflowing that. Describing your numa setup,
 > excluding few bad bits of ram using memmap=exact, set up your boot
 > over iscsi on cmdline.... these are likely to eat insane ammount of
 > cmdline space.

65535 characters? Are you for real?
Stop and think about just how big that is. If you have to create
a boot command line that long, you have serious, serious issues.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/