Re: [PATCH 2/3] swsusp: Do not use page flags

From: Andrew Morton
Date: Thu Mar 15 2007 - 18:25:14 EST


On Thu, 15 Mar 2007 23:19:02 +0100 (CET)
Jiri Kosina <jikos@xxxxxxxx> wrote:

> On Thu, 15 Mar 2007, Andrew Morton wrote:
>
> > > > And why _does_ suspend use GFP_ATOMIC all over the place?
> > > Generally, because it cannot sleep.
> > Why not?
>
> I guess it's simply beucase of kswapd being already frozen, so there is no
> chance that once GFP_KERNEL allocation goes to sleep, it is going to get
> any free pages eventually ... ?

No, things should run fine with a dead kswapd.

There are reasons why we can't call into filesystems from there, but
GFP_NOIO will ensure that and it is heaps better than GFP_ATOMIC.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/