Re: [PATCH, take2] getrusage() : Fill ru_inblock and ru_oublock fields if possible

From: Oleg Nesterov
Date: Mon Mar 19 2007 - 06:54:16 EST


On 03/19, Eric Dumazet wrote:
>
> +static inline unsigned long task_io_get_inblock(const struct task_struct *p)
> +{
> + return p->ioac.read_bytes >> 9;
> +}
>
> [...snip...]
>
> @@ -2021,6 +2022,8 @@ static void k_getrusage(struct task_stru
> r->ru_nivcsw = p->signal->cnivcsw;
> r->ru_minflt = p->signal->cmin_flt;
> r->ru_majflt = p->signal->cmaj_flt;
> + r->ru_inblock = p->signal->cinblock;
> + r->ru_oublock = p->signal->coublock;
>
> if (who == RUSAGE_CHILDREN)
> break;
> @@ -2032,6 +2035,8 @@ static void k_getrusage(struct task_stru
> r->ru_nivcsw += p->signal->nivcsw;
> r->ru_minflt += p->signal->min_flt;
> r->ru_majflt += p->signal->maj_flt;
> + r->ru_inblock += task_io_get_inblock(p->signal);

p->signal is "struct signal_struct *", not "struct task_struct *" as
task_io_get_inblock() expects ?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/