Re: [PATCH -mm 4/4] Blackfin: on-chip Two Wire Interface I2C driver

From: Jean Delvare
Date: Thu Mar 22 2007 - 05:26:35 EST


On Thu, 22 Mar 2007 04:12:37 -0400, Mike Frysinger wrote:
> it isnt obvious to me how to leverage the normal platform_device and
> resource structures to achieve moving the class out of the driver and
> into a boards file ... i'm perfectly happy doing this knowing what the
> correct direction to take things ... but i guess this gets us back to
> if no one is doing this yet and no one has any proposals, it's on our
> shoulders to get it resolved satisfactorily

I'd say: leave things as they are, if a problem arises, we'll see how
to fix it. By then, the new i2c driver model will be in mainline, which
will gives us a nicer way to address the problem.

> i might also argue (for fun) that some of the bus drivers arent doing
> it correctly ... they should implement support for the specific I2C
> implementation and then a different file for the specific
> [mother]board would contain the specific details

This sounds easy when you're in the embedded world. Now come and try to
support the literally thousands of different PC motherboard models out
there that way!

--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/