Re: [discuss] 2.6.21-rc5-mm1: i386/x86_64 register_die_notifier() change

From: Andi Kleen
Date: Tue Mar 27 2007 - 17:29:35 EST


On Tuesday 27 March 2007 23:26, Adrian Bunk wrote:
> On Mon, Mar 26, 2007 at 08:57:06PM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.21-rc4-mm1:
> >...
> > +move-die-notifier-handling-to-common-code.patch
> >...
> > Misc
> >...
>
> Is the removal of the vmalloc_sync_all() call in register_die_notifier()
> on i386 and x86_64 both intentional and correct?

It's wrong. The die notifier is used by NMIs and that needs vmalloc_sync_all()

Thanks for catching that.


-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/