Re: [PATCH 11/14] get_unmapped_area handles MAP_FIXED on ramfs (nommu)

[David Howells]

Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote:

> -	if (!(flags & MAP_SHARED))
> +	/* Deal with MAP_FIXED differently ? Forbid it ? Need help from some nommu
> +	 * folks there... --BenH.
> +	 */
> +	if ((flags & MAP_FIXED) || !(flags & MAP_SHARED))

MAP_FIXED on NOMMU?  Surely you jest...

See the first if-statement in validate_mmap_request().

If anything, you should be adding BUG_ON(flags & MAP_FIXED).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/