Re: [PATCH 11/90] ARM: OMAP: Add support for Amstrad Delta keypad

[Jonathan McDowell]

On Wed, Apr 04, 2007 at 04:57:57PM -0400, Dmitry Torokhov wrote:
> On 4/4/07, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> 
> >+       KEY(0, 7, KEY_LEFTSHIFT),       /* Vol up       */
> 
> KEY_VOLUMEUP?
> 
> >+       KEY(3, 7, KEY_LEFTCTRL),        /* Vol down  */
> 
> KEY_VOLUMEDOWN?

In terms of making the keypad on top of the E3 usable left shift and
left ctrl make more sense (there are no other keys with this function
and they are to the left of the qwerty layout), but the keys are in fact
labelled vol up/down, hence the comments.

J.

-- 
Revd. Jonathan McDowell, ULC | noodles is good in nagahama
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/