Re: [PATCH 73/90] ARM: OMAP: Add onennand board specific support for N800

[Tony Lindgren]

 * Randy Dunlap <randy.dunlap@xxxxxxxxxx> [070404 16:37]:
> On Wed,  4 Apr 2007 14:05:52 -0400 Tony Lindgren wrote:
> 
> > From: Jarkko Lavinen <jarkko.lavinen@xxxxxxxxx>
> > 
> > Add onennand board specific support for N800
> > 
> > Signed-off-by: Jarkko Lavinen <jarkko.lavinen@xxxxxxxxx>
> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > ---
> >  arch/arm/mach-omap2/board-n800-flash.c |   97 +++++++++++++++++++++++++++++++-
> >  include/asm-arm/arch-omap/onenand.h    |    1 +
> >  2 files changed, 97 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-n800-flash.c b/arch/arm/mach-omap2/board-n800-flash.c
> > index cd302ab..4005cfb 100644
> > --- a/arch/arm/mach-omap2/board-n800-flash.c
> > +++ b/arch/arm/mach-omap2/board-n800-flash.c
> 
> >  static struct omap_onenand_platform_data n800_onenand_data = {
> >  	.cs = 0,
> >  	.gpio_irq = 26,
> >  	.parts = n800_partitions,
> > -	.nr_parts = 0 /* filled later */
> > +	.nr_parts = 0, /* filled later */
> > +	.onenand_setup = n800_onenand_setup
> >  };
> 
> FYI, it's common practice to put a comma at the end of the last
> item, like
> 
> > +	.onenand_setup = n800_onenand_setup,
> 
> That won't generate a syntax error (with gcc) and it allows someone
> to add lines after it without touching that line (e.g., like the
> nr_parts line here).

Updated patch following.

Tony