Re: What protects cpu_tlbstate?

[Jeremy Fitzhardinge]

Andi Kleen wrote:
>> Hm, I was more wondering about simple compiler reordering.  Does the
>> relative order of setting and reading cpu_tlbstate.state, active_mm and
>> the mm->cpu_vm_mask matter?
>>     
>
> Hmm, perhaps a barrier between state and active_mm might be a good idea.
> Setting active_mm after state might be problematic.
> cpu_vm_mask should be already a memory barrier.
>   

Should leave_mm update active_mm and set the state to TLBSTATE_OK?  Just
reloading cr3 seems a bit blunt.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/