Re: [RFC][PATCH -mm] swsusp: Use rbtree for tracking allocated swap

From: Nigel Cunningham
Date: Mon Apr 09 2007 - 17:01:14 EST


Hi.

On Mon, 2007-04-09 at 15:03 +0200, Rafael J. Wysocki wrote:
> On Sunday, 8 April 2007 23:07, Nigel Cunningham wrote:
> [--snip--]
> > > > Normal usage in both cases is simply iterating through the list, so I
> > > > guess the cost would be approximately the same.
> > > >
> > > > Deletion could would include rebalancing for the rb_nodes.
> > >
> > > In swsusp the deletions are needed only if there's an error.
> >
> > When freeing swap at the end of the cycle?
>
> That depends on what you mean by 'the end'. :-)
>
> We free swap if the image saving fails only, since it's allocated after we've
> created the image. After the resume, the state of swap from before the image
> creation is the current one anyway.

Ah, of course. I forgot that temporarily.

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/