Re: [QUICKLIST 3/4] Quicklist support for x86_64

From: Andrew Morton
Date: Mon Apr 09 2007 - 17:46:59 EST


On Mon, 9 Apr 2007 11:25:20 -0700 (PDT)
Christoph Lameter <clameter@xxxxxxx> wrote:

> -static inline pgd_t *pgd_alloc(struct mm_struct *mm)
> +static inline void pgd_ctor(void *x)
> +static inline void pgd_dtor(void *x)

Seems dumb to inline these - they're only ever called indirectly, aren't
they?

This means (I think) that the compiler will need to generate an out-of-line
copy of these within each compilation unit which passes the address of these
functions into some other function.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/