RE: [PATCH 2/2] NET: Multiqueue network device support implementation.

[Waskiewicz Jr, Peter P]

> Hi,
> 
> 
> On Apr 9 2007 14:28, Peter P Waskiewicz Jr wrote:
> >@@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev)  {  
> >#ifdef CONFIG_SYSFS
> > 	/*  Compatibility with error handling in drivers */
> >+	kfree((char *)dev->egress_subqueue);
> > 	if (dev->reg_state == NETREG_UNINITIALIZED) {
> > 		kfree((char *)dev - dev->padded);
> > 		return;
> >@@ -3356,6 +3370,7 @@ void free_netdev(struct net_device *dev)
> > 	/* will free via device release */
> > 	put_device(&dev->dev);
> > #else
> >+	kfree((char *)dev->egress_subqueue);
> > 	kfree((char *)dev - dev->padded);
> > #endif
> > }
> 
> Ahem. Explain that cast.

Jan,
	This can be removed if needed; however, I'm just copying what
the other kfree()'s are doing in this function.  Any instance of a
typecast that I introduced in these patches are just following what
others have done in that section of the code.  So the cast is just for
consistency in this particular area.  If you'd like me to remove it, I
can do that.

Thanks,

-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/