Re: [PATCH 2/2] Allow percpu variables to be page-aligned

[Jeremy Fitzhardinge]

Eric W. Biederman wrote:
> Jeremy Fitzhardinge <jeremy@xxxxxxxx> writes:
>
>   
>> Let's allow page-alignment in general for per-cpu data (wanted by Xen, and
>> Ingo suggested KVM as well).
>>
>> Because larger alignments can use more room, we increase the max per-cpu
>> memory to 64k rather than 32k: it's getting a little tight.
>>     
>
> The second paragraph of the comment is dated.  You are not changing the per-cpu 
> memory size at all now.
>   

Yup.

> Although we should probably fail the module load if the requested alignment
> is to great, but that is just picking nits, and is no worse than what we
> do today.
>   

Yes.  And we barely support a module's use of page-aligned data, since
it would potentially chew through the percpu space very quickly.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/