Re: [-mm3 PATCH] (Retry) Check the return value of kobject_add andetc.

[Andrew Morton]

On Wed, 11 Apr 2007 14:45:25 +0800 WANG Cong <xiyou.wangcong@xxxxxxxxx> wrote:

> >-		snprintf(p->kobj.name,KOBJ_NAME_LEN,"%sp%d",disk->kobj.name,part);
> >+		snprintf(p->kobj.name, KOBJ_NAME_LEN, "%sp%d",
> >+				disk->kobj.name, part);
>                                                ^^^
> Andrew, it seems that you left an additional whitespace in the above line (marked as ^^^).
> 
> > 	else
> >-		snprintf(p->kobj.name,KOBJ_NAME_LEN,"%s%d",disk->kobj.name,part);
> >+		snprintf(p->kobj.name, KOBJ_NAME_LEN, "%s%d",
> >+				disk->kobj.name, part);
>                                                ^^^
> Also here. ;-p

Those are known as "fixes" ;)

One shouldn't mix whitespace fixes with functional changes really, but I
can't help myself.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/