Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

From: Andrew Morton
Date: Thu Apr 12 2007 - 13:01:59 EST


On Thu, 12 Apr 2007 18:45:39 +0200 Andi Kleen <ak@xxxxxxxxxx> wrote:

>
> > I was proposing that i386 and x86_64 be given a new, lockless,
> > high-resolution printk_clock(). Presently x86 uses the default
> > printk_clock(), which uses sched_clock(). Presumably copying the
> > pre-x86_64-mm-sched-clock-share.patch version of sched_clock() into
> > printk_clock() will suffice.
>
> Ok. I think it's better to just fix sched_clock() again than to
> add another one. I can probably
> eliminate the ktime_get() and use something based on jiffies. That will
> be inaccurate for the instable case of course.

hm. People (ab)use sched_clock() for all sorts of things nowadays. I wouldn't
do anything to degrade it just on behalf of printk-timestamping.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/