Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

From: Jeremy Fitzhardinge
Date: Thu Apr 12 2007 - 15:42:41 EST


Andi Kleen wrote:
> They should always just store the cpu too and educate the users that
> only (cpu, timestamp) pairs make sense to compare.
>
> That said at least my new sched_clock should not normally show
> large non differences between CPUs, so it can be usually ignored, but they can
> happen. I believe some of the already existing sched_clocks() (like the
> one used on Altix) have the same property.
>
> But on VMI/Xen as currently implemented the differences will be large.

Yes, it's pretty much unavoidable. It seems to me that these
non-scheduler uses of sched_clock should use something else. Or we
could add a new clock function for the scheduler to use, but
"sched_clock" seems like the best name for it.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/