Re: 2.6.21-rc6-mm1 USB related boot hang

[Jiri Kosina]

On Thu, 12 Apr 2007, Helge Hafting wrote:

> Are you sure this is the correct patch - against 2.6.21-rc6-mm1 ?
> Hunk 1 out of 1 failed . . .

Well I am pretty sure:

box:~/scratch # wget ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc6/2.6.21-rc6-mm1/2.6.21-rc6-mm1.bz2>/dev/null 2>&1
box:~/scratch # wget ftp://ftp.kernel.org/pub/linux/kernel/v2.6/linux-2.6.20.tar.bz2>/dev/null 2>&1
box:~/scratch # wget ftp://ftp.kernel.org/pub/linux/kernel/v2.6/testing/patch-2.6.21-rc6.bz2>/dev/null 2>&1 
box:~/scratch # tar xf linux-2.6.20.tar.bz2
box:~/scratch # cd linux-2.6.20/
box:~/scratch/linux-2.6.20 # mv ../patch-2.6.21-rc6.bz2 .
box:~/scratch/linux-2.6.20 # bunzip2 patch-2.6.21-rc6.bz2
box:~/scratch/linux-2.6.20 # patch -p1 < patch-2.6.21-rc6 >/dev/null 2>&1; echo $?
0
box:~/scratch/linux-2.6.20 # mv ../2.6.21-rc6-mm1.bz2 .
box:~/scratch/linux-2.6.20 # bunzip2 2.6.21-rc6-mm1.bz2
box:~/scratch/linux-2.6.20 # patch -p1 < 2.6.21-rc6-mm1 >/dev/null 2>&1; echo $?
0
box:~/scratch/linux-2.6.20 # cat tmp.patch
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 1ddca31..d930f62 100644
--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -1550,15 +1550,22 @@ static int __init hid_init(void)
        retval = hiddev_init();
        if (retval)
                goto hiddev_init_fail;
+       printk(KERN_DEBUG "hid_init: before usb_register()\n");
        retval = usb_register(&hid_driver);
+       printk(KERN_DEBUG "hid_init: after usb_register(), retuned %d\n", 
retval);
        if (retval)
                goto usb_register_fail;
        info(DRIVER_VERSION ":" DRIVER_DESC);

+       printk(KERN_DEBUG "hid_init: returning 0\n");
+       dump_stack();
        return 0;
 usb_register_fail:
+       printk(KERN_DEBUG "hid_init: calling hiddev_exit()\n");
        hiddev_exit();
 hiddev_init_fail:
+       printk(KERN_DEBUG "hid_init: returning %d\n", retval);
+       dump_stack();
        return retval;
 }
box:~/scratch/linux-2.6.20 # patch -p1 < tmp.patch
patching file drivers/hid/usbhid/hid-core.c
box:~/scratch/linux-2.6.20 #

So I guess you are operating on some broken version of 2.6.21-rc6-mm1 
codebase if you are getting rejects on this trivial patch.


Anyway, based on information you have provided in your later messages, it 
seems that it is probably not necessairly related neither to USB nor HID, 
as you are getting hangs at different stages of boot, depending on your 
local configuration/kernel version used.

Is vanilla 2.6.21-rc6 ok? If so, would you have time to bisect the 
offending patch?

Thanks,

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/