Re: [PATCH] worker_thread: don't play with SIGCHLD

[Oleg Nesterov]

On 04/13, Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@xxxxxxxxxx> writes:
> 
> > depends on Eric's
> >
> > 	kthread-dont-depend-on-work-queues-take-2.patch
> >
> > worker_thread() inherits ignored SIGCHLD from its parent, kthreadd.
> > We can remove unneeded do_sigaction().
> 
> Acked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> 
> Looks good.
> 
> We could delete all of:
> 
> > 	set_user_nice(current, -5);
> > 
> > 	/* Block and flush all signals */
> > 	sigfillset(&blocked);
> > 	sigprocmask(SIG_BLOCK, &blocked, NULL);
> > 	flush_signals(current);

this one is already deleted in -mm...

> > 	/*
> > 	 * We inherited MPOL_INTERLEAVE from the booting kernel.
> > 	 * Set MPOL_DEFAULT to insure node local allocations.
> > 	 */
> > 	numa_default_policy();

Yes, I forgot about this!

> If we wanted to, as that all comes by default from kthreadd.

Thanks, will send an update.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/