Re: drivers/video/output.c

From: Antonino A. Daplas
Date: Tue Apr 17 2007 - 19:44:21 EST


On Tue, 2007-04-17 at 17:37 -0400, Dave Jones wrote:
> commit 2dec3ba8d872aa3ffbcdb8f6f8a2c0bcd44e9910 puzzles me.
>
> git-bisect just fingered it as responsible for my "backlight doesn't turn on"
> suspend/resume regression on the Thinkpad X60. I think it's lying.
>
> Why? Because afaict, drivers/video/output.c is never compiled.
> That commit adds the driver, but doesn't touch any Makefile, and I
> don't see anything obvious in the follow-in commits that would 'enable' it.
>
> Asides from git-bisect failing me again[1], what gives with this file?

Correct, it's basically dead code. Even if you compile it, but without
any users, it shouldn't do anything.

BTW, it's completely independent from framebuffer and backlight and I
doubt the commit is the cause of your problem.

Tony



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/