Re: [RFC 4/8] Enhance fallback functions in libs to support higherorder pages

[Christoph Lameter]

On Fri, 20 Apr 2007, Dave Kleikamp wrote:

> On Fri, 2007-04-20 at 12:05 +0100, Mel Gorman wrote:
> 
> > comments about missing page_cache_size() covered elsewhere. However, I
> > note that Dave Kleikamp might be interested in this changing of
> > page_cache_size() from the perspective of page cache tails. I've added
> > him to the cc so he can take a quick look.
> 
> Yeah.  I'm working on patches for storing file tails in buffers
> allocated from the slab cache, and the tail will be represented by a
> fake struct page.  (This is primarily for kernels with a larger page
> size).  So my version of page_cache_size(page) may return a different
> size for different pages belonging to the same mapping.  I'm in the
> midst of cleaning up the patches and plan to post them to linux-mm by
> Monday.

I am not sure what the point of that patchset would be in this context 
given that this is about support for arbitrary page sizes. If the 
filesystem wants it then it can reduce the page size for small files.

Different page sizes for one mapping may introduce high complexity into a 
filesystem.

And we can already represent different page size. We have compound pages 
support in the kernel.

page_cache_size(page) in terms of current code in mm is

PAGE_SIZE << compound_order(page)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/