Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

[Sergei Shtylyov]

Hello, once I wrote:

> > [PATCH] ide: make ide_hwif_t.ide_dma_host_on void

> > * since ide_hwif_t.ide_dma_host_on is called either when 
> > drive->using_dma == 1
> >   or when return value is discarded make it void, also drop "ide_" prefix
> > * make __ide_dma_host_on() void and drop "__" prefix

>    BTW, it would also make sense to make hwif->ide_dma_timeout() and 
> hwif->ide_dma_lostirq void too (and possibly drop the ide_ prefix). 
> Their results are *explicitly* ignored.

  I've started preparing the patches and found out that aec62xx has completely bogus ide_dma_timeout() -- the same as ide_dma_lostirq() and it doesn't even call __ide_dma_timeout()... :-/
  Don't know whether to deal with this in a separate patch...

MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/