Re: [PATCH] utilities: add helper functions for safe 64-bit integeroperations as 32-bit halves

From: Andrew Morton
Date: Sat Apr 21 2007 - 17:08:28 EST


On Sat, 21 Apr 2007 22:01:47 +0100 Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> wrote:

> > > +#define lower_32_bits(n) (sizeof(n) == 8 ? (u32)(n) : (n))
> >
> > n&0xffffffff would be simpler.
> >
> > Do we actually have any call for this?
>
> The only case for all of this we care about is sector_t, which is one
> type, with specific properties (eg always being positive). The rest is
> over-engineering. Call it sector_upper32() do it the simple way and stop
> trying to solve a problem we don't have

James said we have the same problem with dma_addr_t.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/