Re: [PATCH] x86: Fix potential overflow in perfctr reservation

From: Andi Kleen
Date: Sun Apr 22 2007 - 08:14:54 EST



>
> The created a warning storm:

Hmm, yes good idea to fix that. Probably for x86-64 too.

>
> I worry rather a lot about how well runtime tested this very late change
> was,

I tested it with oprofile and checked the nmi watchdog.

> and whether it works correctly even with this fix applied. Perhaps
> we should jsut revert?

Then you get the memory corruption back.

The change really only enlarges the bitmaps a little anyways, it does not
change any algorithms.

-Andi



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/