Re: [PATCH] bluetooth bnep: Convert to kthread API.

From: Christoph Hellwig
Date: Sun Apr 22 2007 - 15:45:31 EST


On Thu, Apr 19, 2007 at 04:24:59PM -0700, Andrew Morton wrote:
> On Thu, 19 Apr 2007 01:58:51 -0600
> "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> wrote:
>
> > From: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> >
> > This patch starts kbenpd using kthread_run replacing
> > a combination of kernel_thread and daemonize. Making
> > the code a little simpler and more maintainable.
> >
> >
>
> while (!atomic_read(&s->killed)) {
>
> ho hum.

Note that this also stands against a full kthread conversion.
Marcel put my old patches for a full kthread conversion in, but
they didn't deal properly with some of the premaure exit cases,
and causes OOPSes.

I don't remember what the problems where, but the case of a thread
terminating earlier and possibly asynchronously is one of the
cases we'll probably have to add to the kthread infrastructure
before all uses of kernel_thread in drivers can be converted.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/