Re: [RFC][PATCH -mm 2/3] freezer: Introduce freezer_flags

[Rafael J. Wysocki]

On Tuesday, 24 April 2007 00:55, Oleg Nesterov wrote:
> On 04/24, Rafael J. Wysocki wrote:
> >
> > Should I clear it in dup_task_struct() or is there a better place?
> 
> I personally think we should do this in dup_task_struct(). In fact, I believe
> it is better to replace the
> 
> 	*tsk = *orig;
> 
> with some helper (like setup_thread_stack() below), and that helper clears
> ->freezer_flags. Say, copy_task_struct().

Hmm, wouldn't that be overkill?  copy_task_struct() would have to do
*tsk = *orig anyway, and we only need to clear one field apart from this.

Some other fields are cleared towards the end of dup_task_struct(), so perhaps
we could clear freezer_flags in there too?

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/