Re: [patch 1/7] libata: check for AN support
From: Olivier Galibert
Date: Tue Apr 24 2007 - 06:23:25 EST
Sorry for replying to Alan's reply, I missed the original mail.
> > +#define ata_id_has_AN(id) \
> > + ((id && (~id)) & ((id) & (1 << 5)))
(a && ~a) & (b & 32)
I don't think that does what you think it does, because at that point
it's a funny way to write 0 ((0 or 1) binary-and (0 or 32)).
I'm not even sure what it is you want. If for the first part you
wanted (id != 0x00 && id != 0xff), please write just that,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/