Re: [RFC] [PATCH] cpufreq: allow full selection of default governors
From: William Heimbigner
Date: Tue Apr 24 2007 - 18:36:18 EST
On Tue, 24 Apr 2007, Dave Jones wrote:
On Tue, Apr 24, 2007 at 09:03:23PM +0000, William Heimbigner wrote:
> The following patches should allow selection of conservative, powersave, and
> ondemand in the kernel configuration.
This has been rejected several times already.
Ondemand and conservative isn't a viable governor for all cpufreq implementations
(ie, ones with high switching latencies). Also, see the comment in the Kconfig
a few lines above where you are adding this.
It may be wise to disable the selection of ondemand, however, conservative was
designed to fix the very problem created by ondemand (the need for high
switching latencies), and this also says nothing about powersave.
Additionally, it seems odd that the kernel would be left in an undefined state
if a governor failed to initalize - rather, shouldn't the governor fail in such
a way as to not cause errors?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/