Re: Getting the new RxRPC patches upstream

From: Oleg Nesterov
Date: Wed Apr 25 2007 - 06:42:44 EST

On 04/25, David Howells wrote:
> Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> > Yes sure. Note that this is documented:
> >
> > /*
> > * Kill off a pending schedule_delayed_work(). Note that the work callback
> > * function may still be running on return from cancel_delayed_work(). Run
> > * flush_workqueue() or cancel_work_sync() to wait on it.
> > */
> No, it isn't documented. It says that the *work* callback may be running, but
> does not mention the timer callback. However, just looking at the
> cancellation function source made it clear that this would wait for the timer
> handler to return first.

Ah yes, it says nothing about what the returned value means...

> However, is it worth just making cancel_delayed_work() a void function and not
> returning anything? I'm not sure the return value is very useful.

cancel_rearming_delayed_work() needs this, tty_io.c, probably somebody else.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at