Re: suspend2 merge (was Re: [Suspend2-devel] Re: CFS and suspend2: hang in atomic copy)
From: Pavel Machek
Date: Thu Apr 26 2007 - 06:31:27 EST
On Thu 2007-04-26 12:17:12, Johannes Berg wrote:
> On Tue, 2007-04-24 at 23:24 +0200, Pavel Machek wrote:
> > I believe uswsusp user/kernel separation is clean enough. Kernel
> > provides "snapshot image" and "resume image". (Thanks go to Rafael for
> > very clean interface).
> The interface isn't even 64/32-bit compatible...
read/write on /dev/snapshot looks ok.
ioctl(SNAPSHOT_FREEZE, UNFREEZE, ATOMIC_RESTORE, FREE, FREE_SWAP_PAGE,
is okay, because it does not pass any data.
returns 0/1 through pointer. Should be ok. (Maybe we should do
error = put_user(in_suspend, (u32 __user *)arg);
...instead, to make it very explicit?
is okay, because it just uses arg directly.
is okay, because it just uses arg directly... and it is in
range 0-3 or something.
...hmm, is this the one you are complaining about? It returns
loff_t through a pointer. Maybe there's another interface
that can return available swap, and we should use that, instead?
returns sector_t through a pointer. NOt sure if that's good
does old_decode_dev(arg). Is that ok?
shares struct resume_swap_area between user and kernel. I
guess that's bad..?
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/