Re: [patch] uml: fix cmpxchg warnings in -mm

From: Sam Ravnborg
Date: Fri Apr 27 2007 - 13:27:24 EST

On Fri, Apr 27, 2007 at 06:18:02PM +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxx>
> I get lot's of these on i386:
> In file included from include/asm/atomic.h:10,
> from include/linux/file.h:9,
> from mm/fadvise.c:12:
> include/asm/arch/atomic.h: In function âatomic_add_unlessâ:
> include/asm/arch/atomic.h:240: warning: implicit declaration of function âcmpxchgâ
> [...]
> The problem seems to be that <asm-i386/atomic.h> assumes that
> <asm/processor.h> pulls in <asm/system.h>.

Then atomic.h should include system.h and not rely on someone else doing it.
Yes - then system.h may be included twice but that's ok.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at