Re: [PATCH 13/30] Use menuconfig objects - IEEE1394
From: Stefan Richter
Date: Sat Apr 28 2007 - 06:42:30 EST
Jan Engelhardt wrote:
> On Apr 27 2007 22:56, Stefan Richter wrote:
>>> -config IEEE1394
>>> +menuconfig IEEE1394
>>> tristate "IEEE 1394 (FireWire) support"
>>> depends on PCI || BROKEN
>>> select NET
>> Unless there are objections, I will merge it into my queue of IEEE 1394
>> updates for Linus.
> Yes, I do have objections now that the ieee1394 is different in
> Now you have two options in the firewire menu, namely the new
> stack and the old stack. Then menuconfig is not really suitable
> So please skip it until the old stack finds its way out (which may
> take some more time, yes).
My idea, which I planned to cast into a patch during this weekend, was
to keep a patch in linux1394-2.6.git's feed to -mm which basically
restores what can now be seen in -mm (one 1394 menu, two big
subsections in it), while Linus' tree gets the menuconfig form.
On the other hand, there may come a period were Linus' tree gets
something like we have in -mm, i.e. the choice to enable one or the
other or both or none of the two stacks.
So, shall I put Jan's patch aside until there is only one stack left?
Or what about:
tristate "IEEE 1394 (FireWire) support"
tristate "new FireWire stack, alias Juju"
depends on FIREWIRE_SUPPORT && !(IEEE1394=y)
tristate "legacy FireWire stack"
depends on FIREWIRE_SUPPORT && !(FIREWIRE=y)
comment "You can have both stacks installed but should blacklist
the modules of one of them. Else modules from both
stacks will be autoloaded on hotplug events."
depends on FIREWIRE && IEEE1394
(Untested pseudo code.) This would add an extra level of yes/no/m
choice for those who want FireWire drivers. But it lets people who
don't want FireWire skip everything at the superordinate menu.
-=====-=-=== -=-- ===--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/