Re: condingstyle, was Re: utrace comments

[Satyam Sharma]

On 5/1/07, John Anthony Kazos Jr. <jakj@xxxxxxxxxxx> wrote:
> > It's horrid. I'd much rather see
> >
> >         if (veryverylengthycondition1 &&
> >             smallcond2 &&
> >             (conditionnumber3a || condition3b)) {
> >                 ...
> >         }
>
>         if (veryverylengthycondition1
>                 && smallcond2
>                 && (conditionnumber3a
>                         || condition3b)) {
>                 ...
>         }
>
> Clear, crisp, and 80-wide. I also like how the logical operator on the
> following line is indented slightly into the condition of the previous
> line. I think this is much more sensical and sensible than using spaces to
> line them up with the parentheses. Makes clear for each operator the
> condition to which it applies.

Hmmm ... I did use the spaces to line up the operators with the
starting column of the _expression_ in the previous lines, not the
parentheses (that would be gross!). Of course, && and || are binary
operators so they apply both to the expression on the previous line as
well as the expression following it on the same line.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/