Re: [patch 00/22] pollfs: filesystem abstraction for pollable objects

[Davi Arnaut]

Davide Libenzi wrote:
> On Wed, 2 May 2007, Davi Arnaut wrote:
>
>   
> > Davide Libenzi wrote:
> >     
> > > On Tue, 1 May 2007, Andrew Morton wrote:
> > >
> > >   
> > >       
> > > > David, could you provide some feedback please?  The patches are stunningly
> > > > free of comments, but you used to do that to me pretty often so my
> > > > sympathy
> > > > is limited ;)
> > > >     
> > > >         
> > > You bastard! :)
> > > Ok, from a brief look ...
> > >
> > > [general]
> > > The code adds an extra indirection over the already existing
> > > file_operations, that IMO already sufficently abstract a file.
> > > The compat code, if I read it correctly, does not support files crossing
> > > 32/64 bits boundaries (exec or SCM_RIGHTS).
> > >
> > >   
> > >       
> > The compat code is not already finished, I plan to address compat
> > code on the next version.
> >     
>
> How? Compat on sys_read/sys_write?
>
>   
Yes. More on that later.
> > > [timers]
> > > Returns a structure instead of a 32 bit counter (ala timerfd), and needs
> > > extra compat code.
> > >   
> > >       
> > Yes, but the compat code will be quite small.
> >     
>
> Why would that be even justified?
>
>
>   
Because the developer may need it.
> > > [signal]
> > > All the discussions that went on for signalfd has been lost. It pins the
> > > task struct and it does not handle process detach signaling.
> > >   
> > >       
> > No, I just went into a different direction.
> >     
>
> I'd say wrong, because signalfd addressed valid concerns of quite a few 
> ppl.
>
>   
So in this case I may borrow some signalfd code :-) I really like the
signalfd approach, but IMHO the code is quite ugly and duplicates
a lot of hairy code.

--
Davi Arnaut
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/