Re: swap-prefetch: 2.6.22 -mm merge plans

From: Michal Piotrowski
Date: Thu May 03 2007 - 12:15:33 EST


Hi,

On 03/05/07, Ingo Molnar <mingo@xxxxxxx> wrote:

* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> - If replying, please be sure to cc the appropriate individuals.
> Please also consider rewriting the Subject: to something
> appropriate.

i'm wondering about swap-prefetch:

mm-implement-swap-prefetching.patch
swap-prefetch-avoid-repeating-entry.patch
add-__gfp_movable-for-callers-to-flag-allocations-from-high-memory-that-may-be-migrated-swap-prefetch.patch

The swap-prefetch feature is relatively compact:

10 files changed, 745 insertions(+), 1 deletion(-)

it is contained mostly to itself:

mm/swap_prefetch.c | 581 ++++++++++++++++++++++++++++++++

i've reviewed it once again and in the !CONFIG_SWAP_PREFETCH case it's a
clear NOP, while in the CONFIG_SWAP_PREFETCH=y case all the feedback
i've seen so far was positive. Time to have this upstream and time for a
desktop-oriented distro to pick it up.

I think this has been held back way too long. It's .config selectable
and it is as ready for integration as it ever is going to be. So it's a
win/win scenario.

I'm using SWAP_PREFETCH since 2.6.17-mm1 (I don't have earlier configs)
http://www.stardust.webpages.pl/files/tbf/euridica/2.6.17-mm1/mm-config
and I don't recall _any_ problems. It's very stable for me.


Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo

Regards,
Michal

--
Michal K. K. Piotrowski
Kernel Monkeys
(http://kernel.wikidot.com/start)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/