Re: [RFC PATCH 3/3] boot bzImages under paravirt

[Eric W. Biederman]

Jeremy Fitzhardinge <jeremy@xxxxxxxx> writes:

> H. Peter Anvin wrote:
>> In 32-bit mode?  Surely you're joking, Mr. Feynman!
>>   
>
> Right, yes.
>
>> What's worse, reloading segments here might be highly unsafe, if the
>> memory previously occupied by the GDT has been overwritten.  Keep in
>> mind the GDT is touched on a segment *load*, not on a segment *access*;
>> in areas such as booting that can be a huge difference.
>>   
>
> Yep, suits me.  I'm happy for the code to assume that at least %cs and
> %ds are sane; I guess %ss too.  We could copy %ds into %[efg]s if we
> want to be sure (since I could imagine a bootloader leaving them in a
> less defined state).
>
> But if the gdt could be missing altogether, then, yes, we should not
> touch them at all.

Peter has a good point here.  We have been reloading segments historically
so the existing boot loaders won't fall over.  If we could load the gdt
in the paravirt solutions all would be simple.

We have real mystery historical cases in Gujin and ELILO.  So it
probably makes sense at this point to force a gdt reload if we can and
otherwise require all of the segments %ds, %es, %fs, %gs to be loaded
with a valid segment, that we can reach everything we need to touch
from.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/