Re: [RFC/PATCH] ext3: remove inode constructor

From: Andrew Morton
Date: Sat May 05 2007 - 05:03:05 EST


On Sat, 5 May 2007 11:58:45 +0300 (EEST) Pekka J Enberg <penberg@xxxxxxxxxxxxxx> wrote:

> On Fri, 4 May 2007, Andrew Morton wrote:
> > I got 100% rejects against this because Christoph has already had
> > his paws all over the slab constructor code everywhere.
> >
> > Was going to fix it up but then decided that we ought to make changes
> > like this to ext4 as well. Ideally beforehand, but simultaneously is
> > OK as long as it's simple enough.
>
> I'll send you proper patches for them (and will convert other filesystems
> too).

May as well.

> On Fri, 4 May 2007, Andrew Morton wrote:
> > btw, for a benchmark I'd suggest just a silly create-10000-files
> > tight loop rather than something more complex like postmark.
>
> Do you want me to redo the benchmarks or are you happy enough with the
> postmark numbers?

I doubt if this is measurable, really. It'll be something like the
difference between an L1 hit and an L2 hit in amongst all the other stuff
we do on a per-inode basis.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/