Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select"

From: Roman Zippel
Date: Mon May 07 2007 - 07:23:15 EST


Hi,

On Mon, 7 May 2007, Krzysztof Halasa wrote:

> Roman Zippel <zippel@xxxxxxxxxxxxxx> writes:
>
> > What's the advantage? The HDLC option is directly before this?
>
> You don't have to know it's required, you can just select a driver
> for your hardware, without enabling HDLC first.

Is this a real problem?
Using select you should also consider removing HDLC as visible option and
use only select. Mixing depends and selects is generally a bad idea.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/