Re: [PATCH] Blacklist Dell Optiplex 320 from using the HPET

From: Henrique de Moraes Holschuh
Date: Mon May 07 2007 - 16:41:49 EST


On Mon, 07 May 2007, Andreas Mohr wrote:
> On Sat, May 05, 2007 at 12:58:15PM -0300, Henrique de Moraes Holschuh wrote:
> > On Sat, 05 May 2007, Thomas Gleixner wrote:
> > > + printk(KERN_WARNING "HPET counter is defect\n");
> >
> > What about
> > printk(KERN_WARNING "HPET counter is stopped\n");
> >
> > which is far more descriptive?
>
> Far more misguiding, rather?

True, one can miss the "is".

> "HPET counter inoperable or defective (no increment found during probing)"?
> (with an optional "please report" part)

Yes, this looks better.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/